Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nchash dependency #11

Open
marshallward opened this issue Jun 16, 2020 · 1 comment
Open

nchash dependency #11

marshallward opened this issue Jun 16, 2020 · 1 comment

Comments

@marshallward
Copy link

marshallward commented Jun 16, 2020

This is more of a discussion point, wanted to get some feedback.

yamanifest is a very lightweight module, except for this one dependency on nchash. Because of nchash, we need both python-netCDF4 and numpy, which are both very much not lightweight modules.

In particular, numpy installs are big and slow, and can make it hard to keep things lightweight. (e.g it's ~80M if I install to $HOME/.local,).

Mostly I wanted to see how much nchash is used. But also, what do you think of making it an optional hash rather than mandatory?

@aidanheerdegen
Copy link
Member

Absolutely. Don't really use it anymore, but not sure how much work it would be to make it optional. Happy to take PRs!

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants