Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test stATOM proposal in CI using an upgrade test #8177

Closed
5 tasks done
turadg opened this issue Aug 11, 2023 · 2 comments
Closed
5 tasks done

test stATOM proposal in CI using an upgrade test #8177

turadg opened this issue Aug 11, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Aug 11, 2023

What is the Problem Being Solved?

The community's stATOM proposal will be tested elsewhere but we're not confident telling the community it's ready until the testing is automated.

Moreover, if we don't include it in the upgrade tests then they will drift from Mainnet. E.g. what is vaultFactory.managers.manager1

Description of the Design

Add the proposal to a deployment upgrade test

The addBrand call should wait for the auction to complete. That signal comes from a subscriber, which should be careful to stop subscribing.

Security Considerations

Scaling Considerations

Test Plan

Auctions continue to work for both. See also #8270

Upgrade Considerations

Tasks

  1. Inter-protocol bug
    dckc
  2. enhancement
    Chris-Hibbert
  3. automerge:rebase bypass:integration
@turadg turadg added the enhancement New feature or request label Aug 11, 2023
@dckc dckc self-assigned this Aug 15, 2023
@turadg turadg changed the title upgrade test with stATOM proposal upgrade test in CI for stATOM proposal Aug 28, 2023
@aj-agoric aj-agoric added this to the Multi Collateral Support milestone Sep 7, 2023
@turadg turadg assigned Chris-Hibbert and unassigned dckc Sep 8, 2023
@dckc
Copy link
Member

dckc commented Sep 11, 2023

includes adding code to handle timing constraints to avoid #8296, #8307
per meeting with @turadg and co

Without a fix, it's crucial that the oracle be started before the auction, and that the new brand is added to the auction after an auction round ends and before the next one starts.

@Chris-Hibbert Chris-Hibbert changed the title upgrade test in CI for stATOM proposal test stATOM proposal in CI using an upgrade test Oct 2, 2023
@dckc dckc self-assigned this Oct 13, 2023
@dckc
Copy link
Member

dckc commented Nov 3, 2023

fixed in Agoric/agoric-3-proposals#4

@dckc dckc closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants