optimize ICQ port allocation #9317
Assignees
Comments
0xpatrickdev
added a commit
that referenced
this issue
Jul 31, 2024
- changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe - closes #9317
0xpatrickdev
added a commit
that referenced
this issue
Jul 31, 2024
- changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe - closes #9317
0xpatrickdev
added a commit
that referenced
this issue
Jul 31, 2024
- changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe - closes #9317
0xpatrickdev
added a commit
that referenced
this issue
Jul 31, 2024
- changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe - closes #9317
mergify bot
added a commit
that referenced
this issue
Jul 31, 2024
refs: #9114 closes: #9317 ## Description - Miscellaneous cleanup related to `CosmosInterchainService` (part of `vat-orchestration`), closing out todos for 1) unnecessary PowerStore abstraction and 2) vow compat for early synchronous returns - Optimizes ICQ Port Allocation by reusing a single port for all ICQ connections ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations js doc added where necessary ### Testing Considerations included tests for new behavior ### Upgrade Considerations these changes are intended to better prepare us for future upgrades
kriskowal
pushed a commit
that referenced
this issue
Aug 27, 2024
- changes logic in provieICQConnection to lazily request a port on the first request, and reuse it in subsequent requests. since the channel is ordered, timeouts and query errors will not affect subsequent queries and this can be considered safe - closes #9317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a security auditor and developer, I want to ensure we are following best practices for ICQ port allocation.
In #9198, we are allocating 1 port per connection. A different approach may be to share a single port for all ICQ Connections.
#9198 (comment)
Description of Design
Since ICQ channels are UNORDERED, it makes a lot of sense just to allocate a single port. Timeouts and query errors won’t affect subsequent queries.
The text was updated successfully, but these errors were encountered: