Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapEvent Sync #670

Open
2 tasks
EgardA opened this issue Sep 27, 2023 · 1 comment · May be fixed by #717
Open
2 tasks

MapEvent Sync #670

EgardA opened this issue Sep 27, 2023 · 1 comment · May be fixed by #717
Assignees
@EgardA
Labels
enhancement New feature or request
Milestone
MVP

Comments

@EgardA
Copy link
Contributor

EgardA commented Sep 27, 2023 •
edited
Loading

For New Contributors

How to contribute

Description

MapEvent.FinalizeEvent()

Sync needed for Settlement Ownership Change

Intended Design

Follow design of this to get a sense of how to do start out and then follow the messages to keep going :)

https://github.com/Bannerlord-Coop-Team/BannerlordCoop/blob/587e19101cbb14f398aef04f6599b117acc0e48f/source/GameInterface/Services/Settlements/Patches/ChangeOwnerOfSettlementPatch.cs

Location

Follow above as well.

Related Issues

Requirements

Create an integration test for your messages

Additional information

Ask in contrib-chat if you require any assistance, we are happy to help you out.

Definition of Done

  • Class level comments exist for all new classes.
  • XUnit tests exist for every method that does not require the game to be ran.
@EgardA EgardA added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2023
@EgardA EgardA added this to the MVP milestone Sep 27, 2023
@EgardA EgardA changed the title MapEvent.FinalizeEvent Sync MapEvent Sync Sep 27, 2023
@EgardA EgardA removed the good first issue Good for newcomers label Dec 25, 2023
@EgardA
Copy link
Contributor Author

EgardA commented Dec 25, 2023

This is more complicated than meets the eye after some testing

@garrettluskey garrettluskey moved this from Todo to In Progress in Private Testing 3 Dec 27, 2023
@EgardA EgardA linked a pull request Dec 30, 2023 that will close this issue
WIP: Map Event Sync (Includes MapEvents, recruitment, prisoners) #717
Draft
10 tasks
@EgardA EgardA moved this from Todo to In Progress in Private Testing 4 Jan 21, 2024
@garrettluskey garrettluskey moved this to In Progress in Sync Backlog Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgardA EgardA

Labels
enhancement New feature or request
Projects
Coop Mod Backlog
Status: Workable
Sync Backlog
Status: In Progress
Private Testing 3
Status: In Progress
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

WIP: Map Event Sync (Includes MapEvents, recruitment, prisoners) Bannerlord-Coop-Team/BannerlordCoop
1 participant
@EgardA