Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to identify company names because they get included with the matched names #15

Open
BirdsAreFlyingCameras opened this issue May 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@BirdsAreFlyingCameras
Copy link
Owner

Because company names are not included in the dictionary (for the most part) and match the name regex that by nature must be broad they must be filtered out. Might also add them as a separate column in the output table but that's an enhancement to be considered post bug fix.

@BirdsAreFlyingCameras BirdsAreFlyingCameras added bug Something isn't working Urgent Get done asap labels May 8, 2024
@BirdsAreFlyingCameras BirdsAreFlyingCameras self-assigned this May 8, 2024
@BirdsAreFlyingCameras
Copy link
Owner Author

I will most likely handle this bug by implementing a list of company names to be checked pre api call.

@BirdsAreFlyingCameras BirdsAreFlyingCameras added enhancement New feature or request bug Something isn't working and removed bug Something isn't working Urgent Get done asap labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant