You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A similar base class with just op method could be used for Gradient and Proximity.
The reason why this will affect is cause I have some more generic proximities and gradients, which cant be inherited from GradParent and ProxParent, which misses the flow and also causes a lot of warnings.
Are you planning to submit a Pull Request?
Yes
No
The text was updated successfully, but these errors were encountered:
Instead of checking the parents/ grand-parents and the whole family tree, why not check only if the child class has the correct methods availables ? Its easily doable using the built-ins hasattr and callable.
Currently, we have
GradParent
andProxParent
base classes.However, it would help to have a more generic Base Operator classes, particularly linear operator class like the OperatorBase in pysap-mri :
https://github.com/CEA-COSMIC/pysap-mri/blob/90c9d12687660a266f029680359a532efdb0db3f/mri/operators/base.py#L9
A similar base class with just op method could be used for Gradient and Proximity.
The reason why this will affect is cause I have some more generic proximities and gradients, which cant be inherited from GradParent and ProxParent, which misses the flow and also causes a lot of warnings.
Are you planning to submit a Pull Request?
The text was updated successfully, but these errors were encountered: