Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Roadmap and Future of ModOpt. #269

Open
4 of 6 tasks
paquiteau opened this issue Dec 17, 2022 · 3 comments
Open
4 of 6 tasks

Development Roadmap and Future of ModOpt. #269

paquiteau opened this issue Dec 17, 2022 · 3 comments
Assignees
Labels
enhancement release New package release PR

Comments

@paquiteau
Copy link
Contributor

paquiteau commented Dec 17, 2022

I reckon that I have started multiple PRs, moving forward here is a proposition for the integration of this work.

I would recommend we use a squash+rebase strategie, to minimize the effect on the main trunk. To smooth things up here is what I propose:

In a later future (e.g. start of Q2 2023), taking the opportunity of a coding sprint:
7. Write test for the new algorithms. This might also be the opportunity to revisite the significance of all optimisation algorithm, to solve a less dummy problem (for instance a LASSO regularised least square)
8. Move the configuration to pyproject.toml , and maybe use a src layout 2, -> this seems to be the new standard 34
9. Release a new ModOpt version (2.0 ? )
10. Write new a paper about it, add it to zenodo5 to get a DOI for the package.

Footnotes

  1. https://pycqa.github.io/isort/docs/configuration/black_compatibility.html

  2. https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/

  3. https://packaging.python.org/en/latest/tutorials/packaging-projects/

  4. https://github.com/pypa/sampleproject

  5. https://zenodo.org/

@sfarrens
Copy link
Contributor

sfarrens commented Jan 2, 2023

Sounds like a good plan to me @paquiteau!

Some other points to consider:

  • Many Python projects are moving away from using setup.py and setup.cfg to exclusively using a pyproject.toml file, perhaps we can consider doing the same for ModOpt. Black can be configured directly in pyproject.toml but requires additional tools for setup.cfg.
  • Should we open an issue to discuss the best way to configure Black for ModOpt?

@paquiteau
Copy link
Contributor Author

I mention the move to pyproject.toml in point 8 ;) Setuping the pyproject.toml should not be a big deal (I am getting pretty good at it and relies already on it for several of my projects, including pysap-fmri). this change of config file could happen simultaneously with the black formatting IMO.

@sfarrens
Copy link
Contributor

sfarrens commented Jan 2, 2023

Sorry I missed that, but since this is tied to the configuration of Black I think point 8 is linked to point 5 and should probably be done in conjunction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release New package release PR
Projects
None yet
Development

No branches or pull requests

3 participants