Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove easy-to-remove direct dependencies #3277

Open
Sbozzolo opened this issue Sep 2, 2024 · 0 comments
Open

Remove easy-to-remove direct dependencies #3277

Sbozzolo opened this issue Sep 2, 2024 · 0 comments

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Sep 2, 2024

#3276 removes a good fraction of dependencies that are not really needed. There are others that can be easily removed:

Adapt

Adapt.adapt(
array_type,
linear_interpolation(
(lon, lat),
esmth,
extrapolation_bc = (Periodic(), Flat()),
),
)

It is used exclusively to generate the spline for Earth topography

Pkg

It is used exclusively to read the artifact file in RRTMGP (will be removed by #3264 )

DiffEqBase

kwargshandle = DiffEqBase.KeywordArgSilent, # allow custom kwargs

It is used only to suppress a warning when passing custom kwargs to solvers

Logging

if ClimaComms.iamroot(comms_ctx)
Logging.global_logger(Logging.ConsoleLogger(stderr, Logging.Info))
else
Logging.global_logger(Logging.NullLogger())
end

Only to disable logging in non-root processes

CliMA/ClimaComms.jl#52

ArtifactsWrapper

It's deprecated, use ClimaArtifacts instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant