Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting #6

Open
DavidBuchanan314 opened this issue Mar 1, 2024 · 1 comment
Open

Rate Limiting #6

DavidBuchanan314 opened this issue Mar 1, 2024 · 1 comment

Comments

@DavidBuchanan314
Copy link
Owner

Given the single-user use-case, we don't have to care much about rate limiting authenticated requests (we can assume the authed user is trustworthy)

But, for any unauthed endpoints, particularly those that trigger outbound traffic (e.g. appview forwarding), we should be careful not to allow spammy requests.

If the AppView ratelimits us, for most cases we're probably fine to forward its response (including rate limit headers) back to the client.

@DavidBuchanan314
Copy link
Owner Author

We should maybe still think about ratelimits for auth'd requests, wouldn't want e.g. a buggy client to cause mayhem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant