Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conway [12.0.0-alpha.3] - Incorrect Credential in DRep Certificates (reg, dereg, update) #637

Closed
Ryun1 opened this issue Aug 24, 2023 · 2 comments
Assignees

Comments

@Ryun1
Copy link

Ryun1 commented Aug 24, 2023

Using Conway Alpha Build: @emurgo/cardano-serialization-lib-nodejs@12.0.0-alpha.3
Based on Draft Conway Ledger design CDDL at commit: 1beddd3d9f10d8fcb163b5e83985c4bac6b74be7

Describe the bug

  • When creating DrepDeregistration, DrepRegistration, DrepUpdate using .new().
  • OR when running .voting_credential() on a DrepDeregistration, DrepRegistration or DrepUpdate.
  • The parameter voting_credential is expected to be of type StakeCredential.
  • This is incorrect, these certificates do not require a stake credential, see ledger design here.

Expected behaviour

  • Rather these certificates should be taking a "DrepCredential" instead, see CDDL, I believe this should be its own new type of Credential.
  • The naming of voting_credential is also outdated to match an older CDDL design and the latest naming is drep_credential.
@lisicky
Copy link
Contributor

lisicky commented Aug 24, 2023

Hi @Ryun1 ! We will name it as Credential. StakeCredential is old legacy name and the new Credential will be a new name for StakeCredential because we use it as a common type.

@lisicky
Copy link
Contributor

lisicky commented Aug 30, 2023

StakeCredential was renamed to Credential in 12.0.0-alpha.4

@lisicky lisicky closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants