Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some method signatures are not remapped properly #113

Open
SpaceWalkerRS opened this issue Oct 5, 2023 · 0 comments
Open

Some method signatures are not remapped properly #113

SpaceWalkerRS opened this issue Oct 5, 2023 · 0 comments

Comments

@SpaceWalkerRS
Copy link

I'm experiencing this issue on a Minecraft jar, so I cannot attach a class file. I'll be looking at a Minecraft 1.13.2 jar (either client or server) and attempting to remap it to some intermediary.

Example 1: class acu with signature <K:Ljava/lang/Object;T::Lacx<TK;TT;>;R:Ljava/lang/Object;>Ljava/lang/Object;>, method b(Ljava/lang/Object;)Lacu$a;, with signature (TK;)Lacu<TK;TT;TR;>.acu$a;, after remapping the method signature is messed up: (TK;)Lnet/minecraft/unmapped/C_0114090<TK;TT;TR;>.a; (note the .a at the end, which should be the intermediary name of acu$a).

Example 2: class tx with signature Lacu<Laxm;Lbnd;Lbnr;>;, method a(Laxm;Z)Lacu$a; with signature (Laxm;Z)Lacu<Laxm;Lbnd;Lbnr;>.acu$a;, after remapping the method signature is messed up: (Lnet/minecraft/unmapped/C_7141926;Z)Lnet/minecraft/unmapped/C_0114090<Lnet/minecraft/unmapped/C_7141926;Lnet/minecraft/unmapped/C_3331146;Lnet/minecraft/unmapped/C_0960638;>.a; (note the .a at the end, which should be the intermediary name of acu$a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant