Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Changing the type of a previously saved hack value crashes game on startup #62

Open
glistermelon opened this issue Feb 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@glistermelon
Copy link
Contributor

Platform

Windows

Version

live build (as of 2/24 7pm)

Describe the bug

iffy about calling this a bug, but in the (unlikely) event that any hack's stored value type is changed, the game will crash every time you start it unless you manually remove the old value from the save file.

won't be an actual problem unless such a change actually happens though, but it's not impossible

Expected Behavior

the game shouldn't crash, and the invalid saved value should probably be erased

How to reproduce

again iffy about calling this a bug because you'll never encounter this unless you're actually developing hacks but

  • add a bool-type hack
  • run the game so that a value is assigned to it and is saved
  • change the hack's type to float
  • run the game again

Mods Installed

devtools and prism menu

Crash Logs

crash occurs in the JSON parser, in any of the as_[type] functions

Additional Context

No response

@glistermelon glistermelon added the bug Something isn't working label Feb 25, 2024
@FireMario211
Copy link
Owner

There isn't really any functionality of "transitioning" hack types over, as I never intended to switch hack types.
I could implement a check where it checks if the type is invalid, and if it is, reset to default value, although this is very unlikely to happen unless someone or I wants to change the hack type to something else.

@glistermelon
Copy link
Contributor Author

glistermelon commented Feb 26, 2024

Yeah. Honestly there's no point in worrying about it unless it actually becomes a problem, especially since no end user will actually encounter it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants