Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests for Github user validation #897

Open
brockfanning opened this issue Mar 10, 2018 · 1 comment
Open

Automated tests for Github user validation #897

brockfanning opened this issue Mar 10, 2018 · 1 comment

Comments

@brockfanning
Copy link
Contributor

Building on the CircleCI integration, it should be possible to implement some approximation of a simple user permission system, where the Github user names of contributors are validated against a curated list. That list would be public, since it would be part of this repository, but it would only contain Github usernames. I'll submit a proof-of-concept for review.

@brockfanning
Copy link
Contributor Author

brockfanning commented Mar 10, 2018

@Kali2017SDG @philipashlock
The proof-of-concept is available as a pull request: #898
The validation is only required when Github users want to change files in the data/ or _indicators folders. There is a short list of administrators who are exempt from the validation. Other users need to have allowed indicators listed. Wildcards can be used to simplify the lists. For example, instead of listing all the indicators under Goal 4, it could just be: 4-*-*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant