Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NurbsCurve checks #337

Open
5 tasks
sonomirco opened this issue Sep 7, 2021 · 2 comments
Open
5 tasks

NurbsCurve checks #337

sonomirco opened this issue Sep 7, 2021 · 2 comments
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.

Comments

@sonomirco
Copy link
Collaborator

sonomirco commented Sep 7, 2021

Checks the following method for closed / periodic curves.

  • Offset
  • Divide
  • PerpendicularFrames
  • SplitAt
  • SubCurve
@sonomirco sonomirco added enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. labels Sep 7, 2021
@d3ssy
Copy link
Collaborator

d3ssy commented Oct 4, 2021

Specify what should happen when checks pass and when checks fail for each method (e.g. SplitAt with a closed curve should throw, return null, or return the original input?)

@sonomirco
Copy link
Collaborator Author

@d3ssy
So all these functions don't check if the NURBS curve is closed (periodic).
So if it is closed has to be clamped first to make the curve usable.

  1. Offset should be able to make the operation even if it is closed.
  2. Divide should clamp the curve first.
  3. PerpendicularFrames should clamp the curve first.
  4. SplitAt should return a closed curve.
  5. SubCurve should clamp the curve first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

No branches or pull requests

2 participants