Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Public Constructor for NURBS with KnotVector #424

Open
skfcz opened this issue Jul 4, 2024 · 1 comment
Open

Add a Public Constructor for NURBS with KnotVector #424

skfcz opened this issue Jul 4, 2024 · 1 comment

Comments

@skfcz
Copy link

skfcz commented Jul 4, 2024

The GShark.Geometry.NurbsCurve does not offer a constructor for NURBS with KnotVector.

This is often necessary when reading NURBS from other sources (e.g. STEP or OCX files).

Please add a publically available constructor, which allows instantiating NURBS with KnotVector.

Currently, I fix that visibility problem with a simple wrapper class

public class OCXNurbsCurve : GShark.Geometry.NurbsBase  {
     public OCXNurbsCurve(int degree, GShark.Core.KnotVector knots, List<Point4> controlPoints) : base(degree, knots,
        controlPoints)
    {
    }
}
skfcz pushed a commit to skfcz/G-Shark that referenced this issue Jul 10, 2024
  Add a Public Constructor for NURBS with KnotVector GSharker#424
@skfcz
Copy link
Author

skfcz commented Jul 10, 2024

See my fork including the changes and a test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant