Replies: 4 comments
-
for write support, i need to improve the value validation. because some registers are having "modes," based on the values of other registers i'll have to add that in some how. what comes to mind is messy, this would suck in csv, so would be best to limit to .json alternatively, can add a condition column to csv... this would also require multi-pass processing of registry values. |
Beta Was this translation helpful? Give feedback.
-
maybe an alternative for 100% verification, is say 75% plus manual verification. ie: user can manually set values on inverter, write those values into prompt, and verify they are correctly read. |
Beta Was this translation helpful? Give feedback.
-
got a new device from china. it's more simple than an inverter, so i'll use that for testing write functionality. added it, new protocol: "hdhk_16ch_ac_module" |
Beta Was this translation helpful? Give feedback.
-
write support has been implemented: 212a285 tested to work with both ushort and sub-ushort values. currently the write topic is a bit different: instead of i'm not certain what is prefered. personally i prefer /write/, but it may interfer with some scripts. probably can add it in the settings manual register verification process still needs to be added. |
Beta Was this translation helpful? Give feedback.
-
I'm waiting for some things to come, so in the meantime i guess i can add write support.
so i think i'll put my notes here on how it will work.
writeable or enabled column?
csv => writeable column:
W = writeable
WD = writeable BUT DISABLED
R = readonly
RD = readonly but DISABLED
OTHER VALUE is assumed to be R
values column MUST BE SET for writeable.
this is for safety, so values should be verified they are within range before sending.
likewise, for safety, BEFORE WRITTING, the register must be read and value verified to bewithin the value range.
optional, push write errors to mqtt.
lastly, should maybe add some sort of verification scan / setup proceedure and a >i'm not reponsible for you bricking your stuff; sort of thing, to enable writing. in order to write, the verification / value scan must be 100%; in the case of it not being 100%, at the very least a user with write access should be able to edit the holding csv to make it 100%.
verification scan will run every startup, and results of scan / write access should be reported to mqtt.
with that, i will also need to clean up the holding register csv for v0.14 to try to achieve 100% verification.
should probably also add a tutorial / readme on users making "custom" versions of their protocols so that they don't get overwritten when updating.
i think this will be the game plan.
Beta Was this translation helpful? Give feedback.
All reactions