Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ModalBottomSheet resets on orientation change #481

Open
nicolarevelant opened this issue Sep 25, 2024 · 0 comments
Open

[BUG] ModalBottomSheet resets on orientation change #481

nicolarevelant opened this issue Sep 25, 2024 · 0 comments

Comments

@nicolarevelant
Copy link

Problem: when I perform this sequence of events the ModalBottomSheet resets:

  1. Touch the buttom at the top right
  2. Touch Settings
  3. Touch Donate
  4. Touch Crypto
  5. Rotate the device twice

Possible solution:

app/src/main/kotlin/com/dot/gallery/feature_node/presentation/support/SupportSheet.kt:45 use rememberSaveable instead of remember

Screenshots:

Version:

2.1.2 (21204) - not fixed in 3.0.0

IacobIonut01 added a commit that referenced this issue Sep 30, 2024
Fixes ModalBottomSheet resets on orientation change #481

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>
@nicolarevelant nicolarevelant changed the title ModalBottomSheet resets on orientation change [BUG] ModalBottomSheet resets on orientation change Oct 7, 2024
IacobIonut01 added a commit that referenced this issue Nov 2, 2024
* Translations: Escape ' correctly with \'

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix imports after sketch update

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Start development for 3.0.1

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Apply 'ignored' rules to Media Picker as well

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Keep Screen On (Again) while watching Videos

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fixed a bug a that prevented direct vertical swipes up on zoomed image

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Update dependencies

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix [BUG] Photo info, black screen #469

Also now the info button works as a toggle (if it is already opened, it will close)

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Gradle: Remove already-enabled flags

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Run UI Events trough the immediate dispatcher

Might fix a random bug where the navigation bar would be visible where it shouldn't be

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix 3.0.0 nomap has internet permission again #471

Thanks @IzzySoft for solution

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Keep ACCESS_NETWORK_STATE permission inheritance

Fixes crash on previous permission removal

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix crash for standalone activity

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* [Standalone] Fix some bugs when Device system bar updates

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix navigation bar display with predictive back gesture animation

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Update AGP to 8.6.1

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Save currentPage in MediaView and use it on restore

Fixes App resets on system-initiated process death #487

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Restore system bars on swipe down

Before:
Swipe down on MediaView when system bars are hidden
The app goes back, but the system bars are still hidden

Now:
Swipe down on MediaView when system bars are hidden
The app goes back, the system bars are back

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Feature: Add hold to rotate photo

Now you can long press to rotate the photo 90 degrees to the right. The change is only visiual and no orientation changes occurs directly on the photo file

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Save showCryptoOptions and reduce clutter in SupportSheet

Fixes ModalBottomSheet resets on orientation change #481

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Search with query only when the user intents to

Fixes SearchBar resets on orientation change #483

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* SearchBar: Improve history management

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Update dependencies

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Try to fix video playing issue in media view

Fixes [BUG] Video issues when viewing album of videos #477

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Allow Video Playback Without Pausing Other Audio

Add new setting to disable audio focus in video player, allowing other apps to play in background while playing videos in the Gallery.

Fixes [Enhancement] Allow Video Playback Without Pausing Other Audio #480

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Improve JXL and HEIF decoders

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Fix compose-material-icons-extended versioning

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Build app by architecture

Generates separate apks for:
- universal
- arm64-v8a
- armeabi-v7a
- x86_64
- x86

Fixes #492

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Add ultra HDR support

Needs testing from supported devices, but it should work

Fixes [Enhancement] Add ultra HDR support #490

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Allow viewing media with full brightness

Add option to set full brightness when viewing media, can be enabled (disabled by default) in the settings screen.

Fixes Set Brightness to maximum  #280

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Dismiss UI automatically when playing videos

Added option in settings (enabled by default)

Fixes [Enhancement] Video UI that doesn't get in your way #416

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Don't display navigation when searchBar is active

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Add support to open the app from camera

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

* Introduce Image Editor v2

Supports:
- Cropping
- Adjustments (Brightness, Contrast..)
- Filters
- Markup (Drawing)

Also adds tablet/landscape optimised layout

Fixes Image editing #1
Fixes [Enhancement] Editor: Drawing #351
Fixes [BUG] Can't crop when I'm not holding makred corners #406
Fixes [Improvement] Cropping #441
Fixes [Enhancement] Please add draw support to edits #494

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>

---------

Signed-off-by: IacobIonut01 <paulionut2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant