New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifetime #69

Open

nrolland opened this issue Sep 15, 2020 · 1 comment

nrolland commented Sep 15, 2020

The lifetime here seem very restrictive

fp-core.rs/fp-core/src/semigroup.rs

Line 2 in 4564c42

fn combine(self, other: Self) -> Self;

Shouldn't that be more something like

fn combine(self, other: &Self) -> Self;

The text was updated successfully, but these errors were encountered:

Owner

JasonShin commented Nov 21, 2020 •

edited

Loading

Thanks for the issue @nrolland, it makes sense to accept a reference for the other param, I will update it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment