Skip to content
This repository has been archived by the owner on Sep 18, 2019. It is now read-only.

0.4 release: speedups don't build with Python 3.7 #17

Open
fkrull opened this issue Nov 3, 2018 · 2 comments
Open

0.4 release: speedups don't build with Python 3.7 #17

fkrull opened this issue Nov 3, 2018 · 2 comments

Comments

@fkrull
Copy link

fkrull commented Nov 3, 2018

The generated speedups.c file included in the tinycss 0.4 release on PyPI doesn't build correctly on Python 3.7. The file was generated with an old version of Cython that didn't support Python 3.7.

Ref: cython/cython#1978
Ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910751

@timokau
Copy link

timokau commented Jan 12, 2019

For what its worth, the current workaround is to manually remove the speedups.c file (since otherwise cython won't regenerate it) and make sure cython is installed during build.

timokau added a commit to timokau/nixpkgs that referenced this issue Jan 12, 2019
The build was broken by the python 3.7 switch, which caused an
incompatible change in the way cython generates files:

Kozea/tinycss#17

This is solved by removing the pre-generated file and re-generating it
at build time.
dotlambda pushed a commit to NixOS/nixpkgs that referenced this issue Jan 12, 2019
The build was broken by the python 3.7 switch, which caused an
incompatible change in the way cython generates files:

Kozea/tinycss#17

This is solved by removing the pre-generated file and re-generating it
at build time.
@fkrull
Copy link
Author

fkrull commented Jan 12, 2019

Yeah, that's how we ended up solving it in the Debian package as well: https://salsa.debian.org/python-team/modules/python-tinycss/commit/632f2d4476721e3e8e606767b270cfd15b6c3c17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants