Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to remove -lflang -lflangrti from Serac Spack Recipe when +rocm #1269

Open
chapman39 opened this issue Nov 12, 2024 · 0 comments
Open

Try to remove -lflang -lflangrti from Serac Spack Recipe when +rocm #1269

chapman39 opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
gpu GPU related TPL Third-party libraries

Comments

@chapman39
Copy link
Contributor

During the process building Serac on tioga/ rzvernal, I likely added more libs than we need in the Serac Spack package here: https://github.com/LLNL/serac/blob/develop/scripts/spack/packages/serac/package.py#L390

            hip_link_flags += "-L{0}/../llvm/lib -L{0}/lib ".format(hip_root)
            hip_link_flags += "-Wl,-rpath,{0}/../llvm/lib:{0}/lib ".format(hip_root)
            hip_link_flags += "-lpgmath -lflang -lflangrti -lompstub -lamdhip64 "
            hip_link_flags += "-L{0}/../lib64 -Wl,-rpath,{0}/../lib64 ".format(hip_root)
            hip_link_flags += "-L{0}/../lib -Wl,-rpath,{0}/../lib ".format(hip_root)
            hip_link_flags += "-lamd_comgr -lhsa-runtime64 "

All of these were copied from Axom, including cases where +fortran. The reason for this was -lpgmath is certainly needed, but it was in Axom's +fortran case. So, I (mistakenly) just added all the fortran-related libs and didn't think much of it.

This has possibly caused another issue which required a band-aid fix of enabling fortran in tioga/ rzvernal builds. https://github.com/LLNL/serac/blob/develop/CMakeLists.txt#L52

I should try to remove the -lflang -lflangrti libs during the next TPL build and see if that allows us to leave fortran disabled on tioga/ rzvernal.

@chapman39 chapman39 added TPL Third-party libraries gpu GPU related labels Nov 12, 2024
@chapman39 chapman39 self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu GPU related TPL Third-party libraries
Projects
None yet
Development

No branches or pull requests

1 participant