Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for Reference Types (Webpack / webassemblyjs) #630

Closed
CryZe opened this issue Oct 16, 2021 · 2 comments · Fixed by #989
Closed

Tracking Issue for Reference Types (Webpack / webassemblyjs) #630

CryZe opened this issue Oct 16, 2021 · 2 comments · Fixed by #989
Labels
enhancement A new feature or general improvement to LiveSplit One. performance Performance is suboptimal and should be improved.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Oct 16, 2021

Reference types (+reference-types) allow passing JavaScript objects into WASM and back. This should improve the performance of the interactions between JS and WASM. All browsers other than Chrome support this already. Chrome will stabilize this in Chrome 96 on November 16th. We would then merge it one month later on December 16th.
@CryZe CryZe added enhancement A new feature or general improvement to LiveSplit One. Chromium An issue that affects Google Chrome, Edge and Opera. performance Performance is suboptimal and should be improved. blocked There's some reason that prevents this work from progressing. labels Oct 16, 2021
@CryZe
Copy link
Collaborator Author

CryZe commented Oct 17, 2021

Turns out that webpack (particularly its underlying library webassemblyjs) can't currently parse WASM files that contain reference types, so this is also blocked on that.

@CryZe
Copy link
Collaborator Author

CryZe commented Nov 17, 2021

Chrome 96 has been released, but webassemblyjs still can't parse reference types. Here's the tracking issue: xtuc/webassemblyjs#931

@CryZe CryZe changed the title Tracking Issue for Reference Types (Chrome 96) Tracking Issue for Reference Types (Webpack / webassemblyjs) Nov 17, 2021
@CryZe CryZe removed the Chromium An issue that affects Google Chrome, Edge and Opera. label May 10, 2024
@CryZe CryZe linked a pull request Nov 5, 2024 that will close this issue
Switch to the web Target of wasm-bindgen #989
Merged
@CryZe CryZe closed this as completed in #989 Nov 5, 2024
@CryZe CryZe removed the blocked There's some reason that prevents this work from progressing. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or general improvement to LiveSplit One. performance Performance is suboptimal and should be improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to the web Target of wasm-bindgen CryZe/LiveSplitOne
1 participant
@CryZe