Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing Pos with Numpy vectors #40

Open
niftymaestro opened this issue Jun 23, 2021 · 3 comments
Open

Investigate replacing Pos with Numpy vectors #40

niftymaestro opened this issue Jun 23, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@niftymaestro
Copy link
Collaborator

See related ticket #28 which does the same for Vector2D, Matrix2D which are used by the Fractal classes

@niftymaestro
Copy link
Collaborator Author

@EL-S @Markichu

I've looked into using Numpy vectors instead of the Pos class.

Would need to extensively refactor Drawing and originalDrawingMethods

A lot of the vector arithmetic would simplify if using a Numpy vector, however we'd have to wrap the Numpy vectors to use in the Drawing, to add the relevant methods needed, and the wrapping class would end up looking a lot like Pos. I think this issue is not quite worth doing (yet)

One improvement could be in Pos to store the coordinate internally as a Numpy vector, instead of self.x, self.y

I'll leave the issue open, but put to the bottom of the list for now.

@niftymaestro niftymaestro removed their assignment Jun 24, 2021
@EL-S
Copy link
Collaborator

EL-S commented Jun 26, 2021

Interesting observations and I agree for now

@davidryan59
Copy link
Collaborator

Low priority, unless someone really wants to refactor. I'll leave it open still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants