Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where candidate and benchmark maps may have differing positive and negative values #69

Open
fernando-aristizabal opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@fernando-aristizabal
Copy link
Member

Current behavior

  • Compute_categorical_metrics only handles cases where the positive and negative values in both maps align.

Expected behavior

  • Handle cases where candidate and benchmark maps may have differing positive and negative values
@fernando-aristizabal fernando-aristizabal added the enhancement New feature or request label Mar 27, 2023
@fernando-aristizabal
Copy link
Member Author

Possibly extend positive_categories and negative_categories arguments to allow dictionaries to be passed with keys of "candidate" and "benchmark".

@fernando-aristizabal
Copy link
Member Author

Do we have a definitive use case for this? We could leave this here in case it's needed bc it does add considerable complexity in terms of code and arguments if implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant