Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not sign-in with msaljs popup on Safari browser based on Samples/auth/Office-Add-in-Microsoft-Graph-React #629

Open
mrphannguyen opened this issue Nov 3, 2023 · 4 comments

Comments

@mrphannguyen
Copy link

mrphannguyen commented Nov 3, 2023

Samples/auth/Office-Add-in-Microsoft-Graph-React

Im trying to use that sample to implement our add-in but it's working on Chrome and Edge but not on Safari.

It shows the popup but automatically closed.
Debugging: The error code from msal is 12006,
image

That is also the main issue we are facing with our add-in on Safari, it worked before but now it's not working.
In our addin, we use msalClient.loginPopup(request), it shows the popup but throws the error: "null or undefined window object" in developer mode and can not close itself.

It's a little bit different from the sample but i think both are the same problem

Environment

  • Platform: Office Online
  • Host: Outlook Web
  • Operating System: Mac OS
  • Browser (if using Office Online): Safari
  • "@azure/msal-browser": "^2.34.0",
    "@azure/msal-react": "^1.5.4",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
@mrphannguyen
Copy link
Author

Hi @yjoshi-msft @peronald do we have any update?

@AlexJerabek
Copy link
Collaborator

@davidchesnut, could you please take a look at this issue and reassign as appropriate?

@davidchesnut
Copy link
Member

Hi @mrphannguyen, I apologize for the delay on responding to this issue. I'm assigning to me for now. I want to check if you are still seeing this behavior. If so I'll see if I can reproduce this issue and track down what is going on.

Thanks,
David

@davidchesnut
Copy link
Member

Reviewing the sample it was getting stale and had several issues. I submitted a PR to bring it up to date. See #750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants