Skip to content

Latest commit

 

History

History
138 lines (88 loc) · 9.39 KB

DEVELOPMENT.md

File metadata and controls

138 lines (88 loc) · 9.39 KB
Raw

VS Code extension for OpShin

  • Uses the built-in linter of opshin: opshin lint
  • The extension calls opshin lint --output-format-json for the current file.
  • This returns an JSON-object which is parsed by _parse_output_using_json in bundled/tool/lsp_server.py.
  • An lsp.Diagnostic object is created which is the data type for vscode to show the linter warning to the user.

Programming Languages and Frameworks

The extension template has two parts, the extension part and language server part. The extension part is written in TypeScript, and language server part is written in Python over the pygls (Python language server) library.

For the most part you will be working on the python part of the code when using this template. You will be integrating your tool with the extension part using the Language Server Protocol. pygls currently works on the version 3.16 of LSP.

The TypeScript part handles working with VS Code and its UI. The extension template comes with few settings pre configured that can be used by your tool. If you need to add new settings to support your tool, you will have to work with a bit of TypeScript. The extension has examples for few settings that you can follow. You can also look at extensions developed by our team for some of the popular tools as reference.

Requirements

  1. VS Code 1.64.0 or greater
  2. Python 3.7 or greater
  3. node >= 14.19.0
  4. npm >= 8.3.0 (npm is installed with node, check npm version, use npm install -g npm@8.3.0 to update)
  5. Python extension for VS Code

You should know to create and work with python virtual environments.

Getting Started

  1. Use this template to create your repo.
  2. Check-out your repo locally on your development machine.
  3. Create and activate a python virtual environment for this project in a terminal. Be sure to use the minimum version of python for your tool. This template was written to work with python 3.7 or greater.
  4. Install nox in the activated environment: python -m pip install nox.
  5. Add your favorite tool to requirements.in
  6. Run nox --session setup.
  7. Optional Install test dependencies python -m pip install -r src/test/python_tests/requirements.txt. You will have to install these to run tests from the Test Explorer.
  8. Open package.json, look for and update the following things:
    1. Find and replace <pytool-module> with module name for your tool. This will be used internally to create settings namespace, register commands, etc. Recommendation is to use lower case version of the name, no spaces, - are ok. For example, replacing <pytool-module> with pylint will lead to settings looking like pylint.args. Another example, replacing <pytool-module> with black-formatter will make settings look like black-formatter.args.
    2. Find and replace <pytool-display-name> with display name for your tool. This is used as the title for the extension in market place, extensions view, output logs, etc. For example, for the black extension this is Black Formatter.
  9. Install node packages using npm install.

Adding features from your tool

Open bundled/tool/lsp_server.py, here is where you will do most of the changes. Look for TODO comments there for more details.

Also look for TODO in other locations in the entire template:

  • bundled/tool/lsp_runner.py : You may need to update this in some special cases.
  • src/test/python_tests/test_server.py : This is where you will write tests. There are two incomplete examples provided there to get you started.
  • All the markdown files in this template have some TODO items, be sure to check them out as well. That includes updating the LICENSE file, even if you want to keep it MIT License.

References, to other extension created by our team using the template:

Building and Run the extension

Run the Debug Extension and Python configuration form VS Code. That should build and debug the extension in host window.

Note: if you just want to build you can run the build task in VS Code (ctrl+shift+B)

Debugging

To debug both TypeScript and Python code use Debug Extension and Python debug config. This is the recommended way. Also, when stopping, be sure to stop both the Typescript, and Python debug sessions. Otherwise, it may not reconnect to the python session.

To debug only TypeScript code, use Debug Extension debug config.

To debug a already running server or in production server, use Python Attach, and select the process that is running lsp_server.py.

Logging and Logs

The template creates a logging Output channel that can be found under Output > mytool panel. You can control the log level running the Developer: Set Log Level... command from the Command Palette, and selecting your extension from the list. It should be listed using the display name for your tool. You can also set the global log level, and that will apply to all extensions and the editor.

If you need logs that involve messages between the Language Client and Language Server, you can set "mytool.server.trace": "verbose", to get the messaging logs. These logs are also available Output > mytool panel.

Adding new Settings or Commands

You can add new settings by adding details for the settings in package.json file. To pass this configuration to your python tool server (i.e, lsp_server.py) update the settings.ts as need. There are examples of different types of settings in that file that you can base your new settings on.

You can follow how restart command is implemented in package.json and extension.ts for how to add commands. You cam also contribute commands from Python via the Language Server Protocol.

Testing

See src\test\python_tests\test_server.py for starting point. See, other referred projects here for testing various aspects of running the tool over LSP.

If you have installed the test requirements you should be able to see the tests in the test explorer.

You can also run all tests using nox --session tests command.

Linting

Run nox --session lint to run linting on both Python and TypeScript code. Please update the nox file if you want to use a different linter and formatter.

Packaging and Publishing

  1. Update various fields in package.json. At minimum, check the following fields and update them accordingly. See extension manifest reference to add more fields:
    • "publisher": Update this to your publisher id from https://marketplace.visualstudio.com/.
    • "version": See https://semver.org/ for details of requirements and limitations for this field.
    • "license": Update license as per your project. Defaults to MIT.
    • "keywords": Update keywords for your project, these will be used when searching in the VS Code marketplace.
    • "categories": Update categories for your project, makes it easier to filter in the VS Code marketplace.
    • "homepage", "repository", and "bugs" : Update URLs for these fields to point to your project.
    • Optional Add "icon" field with relative path to a image file to use as icon for this project.
  2. Make sure to check the following markdown files:
    • REQUIRED First time only: CODE_OF_CONDUCT.md, LICENSE, SUPPORT.md, SECURITY.md
    • Every Release: CHANGELOG.md
  3. Build package using nox --session build_package.
  4. Take the generated .vsix file and upload it to your extension management page https://marketplace.visualstudio.com/manage.

To do this from the command line see here https://code.visualstudio.com/api/working-with-extensions/publishing-extension

Upgrading Dependencies

Dependabot yml is provided to make it easy to setup upgrading dependencies in this extension. Be sure to add the labels used in the dependabot to your repo.

To manually upgrade your local project:

  1. Create a new branch
  2. Run npm update to update node modules.
  3. Run nox --session setup to upgrade python packages.

Troubleshooting

Changing path or name of lsp_server.py something else

If you want to change the name of lsp_server.py to something else, you can. Be sure to update constants.ts and src\test\python_tests\lsp_test_client\session.py.

Also make sure that the inserted paths in lsp_server.py are pointing to the right folders to pick up the dependent packages.

Module not found errors

This can occurs if bundled/libs is empty. That is the folder where we put your tool and other dependencies. Be sure to follow the build steps need for creating and bundling the required libs.

Common one is pygls module not found.