Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict typing on dependencies #36

Closed
JanssenBrm opened this issue May 31, 2024 · 3 comments
Closed

Strict typing on dependencies #36

JanssenBrm opened this issue May 31, 2024 · 3 comments

Comments

@JanssenBrm
Copy link
Collaborator

The typing on the dependencies key is too strict, not allowing it to include additional fields. The strict convention is not necessary as the field is also mapped as flattened in ElasticSearch, so there is no need to search for its detailed properties. Additionally, the strict validation requires an update of the code every time a new field is added.

@JanssenBrm
Copy link
Collaborator Author

Referring to Open-EO/openeo-geopyspark-driver#786, this is the original ticket where this behaviour was detected.

@bossie
Copy link

bossie commented May 31, 2024

Ok, I was under the impression that this was an issue with the mapping but it's in the application instead.

Thanks for the quick fix.

@JanssenBrm
Copy link
Collaborator Author

Indeed I noticed that the application was still applying some typing and validation to the dependencies object so I removed the specific typings. I also checked the other fields and they now all either have a basic type (string, number or boolean) or a generic any type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants