Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ support/serialization.hpp should #include <cassert> #348

Closed
serges147 opened this issue Oct 9, 2024 · 1 comment
Closed

C++ support/serialization.hpp should #include <cassert> #348

serges147 opened this issue Oct 9, 2024 · 1 comment
Assignees
@serges147

Comments

@serges147
Copy link

Compilation fails if prior to #include <nunavut/support/serialization.hpp> there was no assert definition - as a result, client code is required to have it like this:

...
#include <cassert>  // NOLINT for NUNAVUT_ASSERT
#include <nunavut/support/serialization.hpp
...
// other c++ system headers
@serges147 serges147 self-assigned this Oct 9, 2024
@serges147 serges147 mentioned this issue Oct 9, 2024
Merged
@serges147 serges147 mentioned this issue Nov 6, 2024
Merged
@serges147
Copy link
Author

Fixed by PR #352

thirtytwobits pushed a commit that referenced this issue Nov 8, 2024
@serges147
Expose FullNameAndVersion() from a DSDL type. (#352)
afd41a5 
1. Exposed full name of a DSDL type as...
```
struct _traits_
{
    ...
    constexpr const char* FullNameAndVersion() { return "{{ composite_type }}"; }
};
```
Needed for libcyphal's subscriber implementation (see [issue #
380](OpenCyphal-Garage/libcyphal#380))

2. Fix for issue #348 - added `#include <cassert>` for
`nunavut/support/serialization.hpp` file generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serges147