Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using conn consistently throughout #949

Open
jgostick opened this issue Mar 27, 2024 · 2 comments
Open

Using conn consistently throughout #949

jgostick opened this issue Mar 27, 2024 · 2 comments
Labels
api PR tag for breaking changes discussion Requires some thought and input from developers

Comments

@jgostick
Copy link
Member

This may need a bit of thought...currently we accept conns in some places to mean an structuring element, and in other places we have conns=4|8 in 2D and conns=6|26 3D. However, usually we just want to know if we should included diagonal connections or not. Having to generate a strel each time is a pain. And the 4|8, 6|26 is not dimension agnostic, so maybe conn='min'|'max' is better?

Also note that nphase_border actually has include_diagonals as an argument, which should be changed to whatever is decided.

@jgostick
Copy link
Member Author

Here is list of functions which currently use strel as a way to basically say whether you want to include diagonal connections:

  • region_size
  • trim_disconnected_blobs
  • trim_nonpercolating_paths

@jgostick
Copy link
Member Author

And here is a list of functions that use conn=<int> to say the same thing:

  • trim_floating_solid
  • find_disconnected_voxels
  • fill_blind_pores

@jgostick jgostick added discussion Requires some thought and input from developers api PR tag for breaking changes labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api PR tag for breaking changes discussion Requires some thought and input from developers
Projects
None yet
Development

No branches or pull requests

1 participant