Skip to content
This repository has been archived by the owner on Mar 27, 2020. It is now read-only.

Remove Disguise Trigger screen #187

Open
jmatsushita opened this issue Jan 27, 2016 · 3 comments
Open

Remove Disguise Trigger screen #187

jmatsushita opened this issue Jan 27, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@jmatsushita
Copy link
Member

Remove the training for the Calculator trigger (just after the power button training).

Both in the initial install and when redoing the training.

(However do not remove the calculator trigger feature only the training screens)

@jmatsushita jmatsushita added this to the v1.5.0 milestone Jan 27, 2016
@niccs niccs added in progress and removed current labels Feb 1, 2016
niccs added a commit that referenced this issue Feb 1, 2016
#187 removed disguise trigger screen for alarm
@niccs
Copy link
Member

niccs commented Feb 2, 2016

Hi @jmatsushita ,

there are three steps--
1)Power button trigger training.
2)Disguise alarm trigger training
3)Disguise unlock training(long press and unlock)

Currently I have removed Step-2. Do you want me to remove Step-3 also??
In redo Training after advanced settings change , only step -1 is followed.

And there are two app flows:--

  1. App fresh install
  2. app update install of 1.5 version.

In both the flows I am assuming same changes to be done.
Please clarify

@jmatsushita
Copy link
Member Author

Hi @niccs,

This issue is fine and working good on a fresh install! But on update only Step 1) Power button trigger training needs to be launched.

@niccs
Copy link
Member

niccs commented Feb 2, 2016

Hi @jmatsushita ,

  1. For update flow, I have changed to configure separate set of json objects , so as to play step-1 for training.

  2. Regarding the indefinite display of Toast msg in calculator screen:--

Only long duration(3.5 secs) or short duration(2 secs) is permitted from anfroid API.
Right now I have used Long delay, which is used everywhere in app during training screens.In case we want to increase the duration more, I need to customize the implementation of toast class.

Let me know , if that is required.

niccs added a commit that referenced this issue Feb 8, 2016
#187, #143 Added 1.5 update notification and removed disguise training
@niccs niccs added review and removed in progress labels Feb 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants