Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input lag when using image positioning options #263

Open
Rintse opened this issue Jun 29, 2022 · 3 comments
Open

Input lag when using image positioning options #263

Rintse opened this issue Jun 29, 2022 · 3 comments
Labels

Comments

@Rintse
Copy link

Rintse commented Jun 29, 2022

This issue is a....

[x] Bug
[ ] Other kind of issue (Please describe in detail)

Current Behavior

Very laggy input when using options that change image position.

Expected Behavior

No input lag.

Reproduction Instructions

Grab this image: https://i.imgur.com/SBKjnxm.jpeg (Note, this image has a relatively high pixel count)
Run i3lock -i <image> --scale

Environment

Output of i3lock --version:

i3lock version: 2.13.c.4-34-gd846e7c

Where'd you get i3lock-color from?

[ ] AUR package (which one?)
[x] Built from source yourself
[ ] Other (Please describe in detail)

Seems to be different to #45.
All options that change the placement of the image cause similar lag (-t, -C, -F, -M, -L).

@Rintse Rintse changed the title Input lag Input lag when using image positioning options Jun 29, 2022
@Raymo111
Copy link
Owner

Raymo111 commented Jul 27, 2022

What's the full command that you used to launch i3lock-color and get lag with?

@Rintse
Copy link
Author

Rintse commented Jul 27, 2022

I made sure the issue was present with a minimal cfg.
The command in the original post (i3lock -i <image> --scale) already causes lag.

@Raymo111
Copy link
Owner

Raymo111 commented Jul 27, 2022

On every keystroke everything is rerendered, so if the image is large and requires complex resizing/moving, it will be really slow. I'll leave this issue open as a "make rerendering more efficient", but at present I don't have a good fix for this. Related to #159 btw.

@Raymo111 Raymo111 added the perf label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants