You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Charging Refined Storage items in a Portable Energy Storage does nothing.
The issue is that the item is never charging
So I've been stepping through the code, the item does end up charged but the energy handler at RS side always retrieves a new ItemStack
So I checked the code here: https://github.com/Rearth/Oritech/blob/1.21/src/main/java/rearth/oritech/block/base/entity/ExpandableEnergyStorageBlockEntity.java#L145
And I think the issue is that you never "update" the slot with the mutated stack
The flow should be Create container item context -> Call energy handler to charge -> Update the inventory slot with the mutated stack
The container item context is immutable IIRC so changes never get propagated to the backing inventory
Issue description
Charging Refined Storage items in a Portable Energy Storage does nothing.
The issue is that the item is never charging
So I've been stepping through the code, the item does end up charged but the energy handler at RS side always retrieves a new ItemStack
So I checked the code here: https://github.com/Rearth/Oritech/blob/1.21/src/main/java/rearth/oritech/block/base/entity/ExpandableEnergyStorageBlockEntity.java#L145
And I think the issue is that you never "update" the slot with the mutated stack
The flow should be Create container item context -> Call energy handler to charge -> Update the inventory slot with the mutated stack
The container item context is immutable IIRC so changes never get propagated to the backing inventory
TechReborn is suffering from the same problem: TechReborn/TechReborn#3302
Steps to reproduce
Minecraft version
1.21.1 (Latest)
Fabric loader version
0.16.0
Fabric API version
0.102.0+1.21.1
Oritech version
0.9.1
Other relevant versions
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response
The text was updated successfully, but these errors were encountered: