-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide behavior at playlist item end #173
Comments
We currently have an inconsistency at the end of playback. The current publisher preserves the last item while the queue player moves to the next item (default So:
Should behave according to
Possibly later, we don't know what users need yet. Will write a story.
Related problems. Will write a separate story.
Will write a separate story. |
As discussed with @mbruegmann and @NicolasBrunnerSRF and the rest of the team:
This behavior would be consistent with other platforms:
|
To let apps chain between items something like the following should likely be possible, maybe with a dedicated shorter formalism: // ...
.onReceive(player.propertiesPublisher.slice(at: \.playbackState).receiveOnMainThread()) { state in
if state == .ended {
player.play()
player.advanceToNextItem()
}
} A short test shows that this jumps to the last item in the playlist so we probably have a minor bug when advancing to the next item is made at item end. |
A dedicated implementation task has been created. Closed. |
As a user I want a consistent user experience when playback ends. As a Pillarbox integrator I want to have flexibility in choosing how the player behaves when playback ends, in particular at the end of a playlist.
Acceptance criteria
The following questions have found an answer:
nil
?actionAtItemEnd
be customized? (intuition: probably)actionAtItemEnd
to get the behavior they want. For example:actionAtItemEnd
directly?actionAtItemEnd
? E.g.:actionAtItemEnd
or built-in behaviors, if any? Same question if the last item, whose end has been reached, is moved elsewhere in the playlist.Expected output:
Hints (for stories)
testCurrentItemIndexAfterPlayerEnded
) might have to be updated or added in the process.Tasks
The text was updated successfully, but these errors were encountered: