New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not access Letterbox internals in implementing the mini player #144

Closed

defagos opened this issue Apr 30, 2020 · 1 comment

Labels

Member

defagos commented Apr 30, 2020

The mini player implementation still surprisingly uses Letterbox internals.

We shouldn't, and removing this trick would help us verify that other apps can implement a similar mini player bar without cheating as well.

defagos added the improvement label

Member Author

defagos commented Jan 7, 2022

We can live with it I think. This is not optimal but could improve if we improve our Letterbox player API.

defagos closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment