Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS SRGIdentityLoginViewController should send an analytics page view event #35

Open
pyby opened this issue Dec 17, 2019 · 1 comment

Comments

@pyby
Copy link
Member

pyby commented Dec 17, 2019

Issue type

Incorrect behavior

Description of the problem

The tvOS login view should be tracked as a page view.

Environment information

  • Library version: 4.0.0
  • tvOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Launch the demonstration application on tvOS.
  2. Open the login page.
  3. Check that an analytics page view event is sent (ComScore and tag Commander).
@defagos
Copy link
Member

defagos commented Nov 19, 2020

As discussed with @pyby in the context of Letterbox player view controller, maybe the best way is to have the app call the page view tracking method directly when it presents such a view controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants