Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FO: Sorting on "Wijk" does not work #166

Open
someren opened this issue Jan 10, 2022 · 9 comments · Fixed by Amsterdam/signals-frontend#2210
Open

FO: Sorting on "Wijk" does not work #166

someren opened this issue Jan 10, 2022 · 9 comments · Fixed by Amsterdam/signals-frontend#2210
Assignees

Comments

@someren
Copy link

someren commented Jan 10, 2022

BE version 2.3.2
FE version 1.68.0

I created a filter based on status + districts. Then used sorting to alphabetically sort on "Stadsdeel".
The result is incorrect. The disctricts are not sorted correctly.
For example: Empel should be listed above Engelen and disctrict Noord appears in the middle and end of this list
image

Could you please fix this issue?

Possibly related to #165

@someren
Copy link
Author

someren commented Mar 14, 2022

Getest op versie 2.4.1. issue speelt nog steeds.

@tcoenen
Copy link

tcoenen commented Mar 21, 2022

This sorting is hardcoded to use the stadsdeel field on the Location model. That field is only filled for the original Signalen instance in Amsterdam and sorting for area never worked for VNG installations. We need a more general approach than filling the stadsdeel field.

@tcoenen
Copy link

tcoenen commented May 10, 2022

Backend implementation is now awaiting review in Amsterdam. Note that the frontend will still have to implement some changes as well.

@boris-arkenaar boris-arkenaar self-assigned this May 12, 2022
@tcoenen
Copy link

tcoenen commented May 13, 2022

Backend was approved and merged. Will be available on acceptatie likely later today.

@someren
Copy link
Author

someren commented Jun 2, 2022

Getest op versie 2.5. Issue is nog niet opgelost.

@boris-arkenaar
Copy link

Dit vereist nog werk in de frontend

@arvidsmits arvidsmits changed the title Sorting on "Stadsdeel" does not work FO: Sorting on "Stadsdeel" does not work Jun 20, 2022
@bartjkdp
Copy link

Getest met frontend v2.6.2 en backend 2.7.1. Het lijkt een beetje te werken, maar niet echt:

image

Call naar de backend is:

GET https://api.melding.acc.heerlen.nl/signals/v1/private/signals/?page=1&ordering=area_name&page_size=50

@bartjkdp bartjkdp changed the title FO: Sorting on "Stadsdeel" does not work FO: Sorting on "Wijk" does not work Aug 10, 2022
@bartjkdp
Copy link

bartjkdp commented Aug 11, 2022

Lijkt wel te werken op productie, zou misschien iets omgeving-specifieks kunnen zijn van de acceptatieomgeving. Misschien iets met meerdere AreaTypes? Ik duik er nog even in.

@boris-arkenaar
Copy link

In een omgeving waar niet altijd met areas gewerkt is zal het niet (volledig) werken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants