Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Hiding / Sliding up navigation bar on scroll down #659

Open
lekhok opened this issue Aug 20, 2024 · 6 comments
Open

[FEATURE] Hiding / Sliding up navigation bar on scroll down #659

lekhok opened this issue Aug 20, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@lekhok
Copy link

lekhok commented Aug 20, 2024

Description

The website has a big navigation bar, although it's transparent, it can be further improved by implementing a hiding navigation bar on scrolling down the website, so as to provide a bigger visual screen space.

Screenshots

No response

Additional information

No response

@lekhok lekhok added the enhancement New feature or request label Aug 20, 2024
Copy link

It's great having you contribute to this Project

Thank you for noticing & notifying us for this issue in Sukoon. 🤓
If you would like to keep contributing to open-source, you can check out the other projects by Susmita Dey here
Any questions, let us know. 🤓

@KartikChinda
Copy link

Hi, @lekhok. I'd love to work on this issue, Please assign this to me.

@chalky25
Copy link

chalky25 commented Sep 5, 2024

@Susmita-Dey I have edited the code to add this feature however, i want to test it before sending a pull request. How do i go about it?

@KartikChinda
Copy link

KartikChinda commented Sep 5, 2024

@chalky25 I'd suggest you start by reading the general open-source guidelines first. Open source is not about forking the repo, adding a bunch of code and just pushing it. In this particular case, ask for the issue to be assigned to you, let it be assigned to you first, and then and only then should you work on it, especially when someone has already asked to work on the issue beforehand.

@mue864
Copy link

mue864 commented Sep 5, 2024

Hi @lekhok, I'm interested in working on this issue. Can you please assign it to me

@chalky25
Copy link

chalky25 commented Sep 5, 2024

@KartikChinda Thanks for the feedback! I'll also spend more time familiarizing myself with the general open-source protocols once again to ensure I’m adhering to best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants