From ee7129009af72c4452c1e8699d6d49f3b368a119 Mon Sep 17 00:00:00 2001 From: DashieTM Date: Wed, 12 Jun 2024 23:52:09 +0200 Subject: [PATCH] chore: Update todos --- src/components/audio/audio_box_utils.rs | 2 +- src/components/audio/audio_entry.rs | 2 +- src/components/audio/audio_functions.rs | 2 +- src/components/base/error_impl.rs | 2 +- src/components/bluetooth/bluetooth_box.rs | 3 +-- src/components/bluetooth/bluetooth_entry.rs | 2 +- src/components/bluetooth/bluetooth_event_handlers.rs | 2 +- src/components/wifi/saved_wifi_entry.rs | 2 +- src/components/wifi/wifi_box.rs | 2 +- src/components/wifi/wifi_entry.rs | 6 +++--- src/components/wifi/wifi_event_handlers.rs | 2 +- src/components/window/reset_window.rs | 1 - src/components/window/sidebar_entry_impl.rs | 2 +- 13 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/components/audio/audio_box_utils.rs b/src/components/audio/audio_box_utils.rs index a1ef8bc..90ae2b8 100644 --- a/src/components/audio/audio_box_utils.rs +++ b/src/components/audio/audio_box_utils.rs @@ -334,7 +334,7 @@ pub fn start_audio_box_listener< get_default_name_function: &'static DBusFunction, dummy_name: &'static str, ) -> Connection { - // TODO: make the failed logs generically sound -> deynamic output for both + // FUTURE TODO: make the failed logs generically sound -> deynamic output for both let object_added = ObjectAdded::match_rule(Some(&BASE.into()), Some(&Path::from(DBUS_PATH))).static_clone(); let object_changed = diff --git a/src/components/audio/audio_entry.rs b/src/components/audio/audio_entry.rs index f93541f..dafe884 100644 --- a/src/components/audio/audio_entry.rs +++ b/src/components/audio/audio_entry.rs @@ -117,7 +117,7 @@ pub fn new_entry< reset_box: Arc, ) -> Arc { let obj: Arc = Arc::new(Object::builder().build()); - // TODO use event callback for progress bar -> this is the "im speaking" indicator + // FUTURE TODO: use event callback for progress bar -> this is the "im speaking" indicator { let imp = obj.entry_imp(); let slider_obj_ref = obj.clone(); diff --git a/src/components/audio/audio_functions.rs b/src/components/audio/audio_functions.rs index d634100..3ad9f1e 100644 --- a/src/components/audio/audio_functions.rs +++ b/src/components/audio/audio_functions.rs @@ -91,7 +91,7 @@ pub fn new_stream_entry< stream: StreamObject, ) -> Arc { let obj: Arc = Arc::new(Object::builder().build()); - // TODO use event callback for progress bar -> this is the "im speaking" indicator + // FUTURE TODO: use event callback for progress bar -> this is the "im speaking" indicator let output_box_mute_ref = audio_box.clone(); let output_box_volume_ref = audio_box.clone(); let output_box_sink_ref = audio_box.clone(); diff --git a/src/components/base/error_impl.rs b/src/components/base/error_impl.rs index 9830b3c..5840055 100644 --- a/src/components/base/error_impl.rs +++ b/src/components/base/error_impl.rs @@ -54,7 +54,7 @@ pub fn show_error( parent: Arc, message: &'static str, ) { - // TODO: Add error to log + // FUTURE TODO: Add error to log glib::spawn_future(async move { glib::idle_add_once(move || { let error = parent.error(); diff --git a/src/components/bluetooth/bluetooth_box.rs b/src/components/bluetooth/bluetooth_box.rs index 4f41cf9..d299908 100644 --- a/src/components/bluetooth/bluetooth_box.rs +++ b/src/components/bluetooth/bluetooth_box.rs @@ -57,7 +57,7 @@ impl BluetoothBox { } } -// TODO +// FUTURE TODO: // handle bonded -> this means saved but not connected // handle rssi below x -> don't show device @@ -185,7 +185,6 @@ pub fn populate_connected_bluetooth_devices( listeners: Arc, bluetooth_box: Arc, ) { - // TODO handle saved devices -> they also exist gio::spawn_blocking(move || { let ref_box = bluetooth_box.clone(); let adapters = get_bluetooth_adapters(ref_box.clone()); diff --git a/src/components/bluetooth/bluetooth_entry.rs b/src/components/bluetooth/bluetooth_entry.rs index 87323c3..94a9099 100644 --- a/src/components/bluetooth/bluetooth_entry.rs +++ b/src/components/bluetooth/bluetooth_entry.rs @@ -70,7 +70,7 @@ impl BluetoothEntry { }); let gesture = GestureClick::new(); // paired is not what we think - // TODO implement paired + // FUTURE TODO: implement paired gesture.connect_released(move |_, _, _, _| { let imp = entry_ref.imp(); let borrow = imp.bluetooth_device.borrow(); diff --git a/src/components/bluetooth/bluetooth_event_handlers.rs b/src/components/bluetooth/bluetooth_event_handlers.rs index f29892b..c32d103 100644 --- a/src/components/bluetooth/bluetooth_event_handlers.rs +++ b/src/components/bluetooth/bluetooth_event_handlers.rs @@ -69,7 +69,7 @@ pub fn device_removed_handler( if list_entry.imp().bluetooth_device.borrow().connected { imp.reset_bluetooth_connected_devices.remove(&*list_entry); } else { - // TODO: is there a better way for this? + // FUTURE TODO: is there a better way for this? imp.reset_bluetooth_available_devices.remove(&*list_entry); imp.reset_bluetooth_saved_devices.remove(&*list_entry); } diff --git a/src/components/wifi/saved_wifi_entry.rs b/src/components/wifi/saved_wifi_entry.rs index 5059a32..985edbd 100644 --- a/src/components/wifi/saved_wifi_entry.rs +++ b/src/components/wifi/saved_wifi_entry.rs @@ -55,7 +55,7 @@ impl SavedWifiEntry { let entry_ref = entry.clone(); delete_button.connect_clicked(clone!(@weak wifi_box => move |_| { delete_connection(entry_ref.imp().reset_connection_path.take()); - // TODO handle error + // FUTURE TODO: handle error wifi_box.reset_stored_wifi_list.remove(&*entry_ref); })); diff --git a/src/components/wifi/wifi_box.rs b/src/components/wifi/wifi_box.rs index ff06ca6..5f4ab7b 100644 --- a/src/components/wifi/wifi_box.rs +++ b/src/components/wifi/wifi_box.rs @@ -209,7 +209,7 @@ pub fn show_stored_connections(wifi_box: Arc) { glib::idle_add_once(move || { let self_imp = wifibox_ref.imp(); for connection in connections { - // TODO include button for settings + // FUTURE TODO: include button for settings let name = &String::from_utf8(connection.1).unwrap_or_else(|_| String::from("")); let entry = SavedWifiEntry::new(name, connection.0, self_imp); diff --git a/src/components/wifi/wifi_entry.rs b/src/components/wifi/wifi_entry.rs index 07779d9..54d42de 100644 --- a/src/components/wifi/wifi_entry.rs +++ b/src/components/wifi/wifi_entry.rs @@ -48,7 +48,7 @@ impl WifiEntry { .build(), ); - // TODO handle encryption thing + // FUTURE TODO: handle encryption let wifi_strength = Image::builder() .icon_name(match strength { WifiStrength::Excellent => "network-wireless-signal-excellent-symbolic", @@ -177,7 +177,7 @@ pub fn click_stored_network(entry: Arc) { }); }); }); - // TODO crate spinner animation and block UI + // FUTURE TODO: crate spinner animation and block UI } pub fn click_new_network(entry: Arc) { @@ -228,7 +228,7 @@ pub fn click_new_network(entry: Arc) { }); }); }); - // TODO crate spinner animation and block UI + // FUTURE TODO: crate spinner animation and block UI }; let entry_imp = entry.imp(); diff --git a/src/components/wifi/wifi_event_handlers.rs b/src/components/wifi/wifi_event_handlers.rs index 6cea57c..9bf42b1 100644 --- a/src/components/wifi/wifi_event_handlers.rs +++ b/src/components/wifi/wifi_event_handlers.rs @@ -72,7 +72,7 @@ pub fn access_point_changed_handler(wifi_box: Arc, ir: AccessPointChang let name = name_opt.as_str(); entry_imp.wifi_strength.set(strength); entry.set_title(name); - // TODO handle encryption thing + // FUTURE TODO: handle encryption thing entry_imp .reset_wifi_strength .borrow() diff --git a/src/components/window/reset_window.rs b/src/components/window/reset_window.rs index 9ac8b90..f72d552 100644 --- a/src/components/window/reset_window.rs +++ b/src/components/window/reset_window.rs @@ -207,7 +207,6 @@ impl ReSetWindow { .connect_row_activated(clone!(@ weak self_imp => move |_, _| { self_imp.reset_search_entry.set_text(""); })); - // TODO: refactor this let mut i = 0; for info in sidebar_list { if info.parent.is_none() && i != 0 { diff --git a/src/components/window/sidebar_entry_impl.rs b/src/components/window/sidebar_entry_impl.rs index 0064ea5..349c203 100644 --- a/src/components/window/sidebar_entry_impl.rs +++ b/src/components/window/sidebar_entry_impl.rs @@ -11,7 +11,7 @@ use crate::components::window::sidebar_entry; #[derive(Default)] pub enum Categories { - // TODO: are these ever used ? + // FUTURE TODO: are these ever used ? // Connectivity, // Audio, // Peripherals,