Idea to improve library

[abuzuhri]

Any one have idea for improve library are welcome write it here , I will be happy to have this library more and more used .
will do my best when I have free time

[J-W-Chan]

hi. abuzuhri
i think we should find a better way to impletment multiple version for SP-API.
eg:

1. CatalogItem API v2020-12-01 the parameter "includedData" is support the args "variations".
   
2. CatalogItem API v2022-04-01 the parameter "includedData" is not support the args "variations".
   

[J-W-Chan]

by the way. the api result is also particle different for the different version. @abuzuhri

[abuzuhri]

This weekend will work on this

[abuzuhri]

Here May Update and we need to be Updated
https://github.com/amzn/selling-partner-api-docs/discussions/2289

[J-W-Chan]

I have completed the "getmyfeesestimates" api

[Paul-J-Barrett]

When someone originally took the swagger document to generate the library is it possible to now generate a swagger from the Library to compare to the original? I ask this because of the pull request I made to fix an issue in the FBAInbound GetShipments would probably show up in such a comparison. Or has there just been to much deviation at this point?

I wish I knew swagger enough to do this but there are only so many hours in my days. It might be use full to have a swagger doc built during the build process then it could be compared by the community. Thoughts?

[J-W-Chan]

I have upgraded restsharp from 106 to 108, and synchronized changes from the main branch @abuzuhri
https://github.com/J-W-Chan/Amazon-SP-API-CSharp/tree/updateToRestsharp108

[abuzuhri]

Please wait Don't push it I need to test it

[J-W-Chan]

Please wait Don't push it I need to test it

Do we need new branches？

[abuzuhri]

I think it's better to have it in new branch

[J-W-Chan]

Ok. I've done a simple test. If the new branch is available, please help merge into the new branch

[nfzv]

Would be great to get rid of Newtonsoft.Json

Thank you for the library, it is great, however the Newtonsoft.Json package that comes with it, may bring conflicts with System.Text.Json.JsonSerializer

This is of course a suggestion, but would be great to see.

Newtonsoft was replaced by Microsoft, and I believe its much preferable to use that, especially in packages.
A little background
Might be useful

It may require significant changes, haven't looked at the source yet, but will try my best to PR that sometime

[feetpeoplellc]

Suggestion: Break reports out from the project.

Downloading reports could be its own project as it is isolated from other tasks and is basically the same for any report. Maybe this would simplify the overall project for others, as well. Simply because the process for reports is the same logic for all of them.

[brm121966]

Hi,
Pass the parameters of functions and procedures as an array or object, not as separate parameters.
Thanks.

[smargoli2]

Hi,
An option to add the User-Agent header on all requests would be nice. Can you point me in the direction of where I could possibly add this and make a PR?

[gilmore1996]

I'm not sure if I can't find it or if its not implemented but can you implement the /finances/2024-06-19/transactions GET method? This method is quite important now that deffered transactions aren't included in the shipment event list of the v0 Finance methods

[Paul-J-Barrett]

I have ran into this issue also and have tickets open with amazon. The two events that are missing that we currently care about are: RemovalShipmentEvent - Need for our various PBI dashboard on inventory. TaxWithholdingEvent - Need for our various tax reporting requirements Unfortunately, I am not really interested in calling the API for individual events. We currently ingest the main financesv0 feed into a datalake for PBI reporting. Having to somehow call individual events might work for some but I don't think it would work for us with our volume.

…

On Mon, Oct 14, 2024 at 6:33 AM gilmore1996 ***@***.***> wrote: I'm not sure if I can't find it or if its not implemented but can you implement the /finances/2024-06-19/transactions GET method? This method is quite important now that deffered transactions aren't included in the shipment event list of the v0 Finance methods — Reply to this email directly, view it on GitHub <#180 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHLW5KWNVYGXOVPZVXWHX3Z3PBZRAVCNFSM6AAAAABOCYYXYWVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAOJTG4YDMNY> . You are receiving this because you commented.Message ID: <abuzuhri/Amazon-SP-API-CSharp/repo-discussions/180/comments/10937067@ github.com>