Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Boolean should be compared strictly - in src/AerialShip/…/Api/QueueController.php, line 72 #86

Open
i3or1s opened this issue Jan 22, 2015 · 0 comments

Comments

@i3or1s
Copy link
Member

i3or1s commented Jan 22, 2015

in src/AerialShip/SteelMqBundle/Controller/Api/QueueController.php, line 72

With booleans, only strict comparison (with === operator) should be used to lower bug risks and to improve performances.

        $form = $this->createForm('queue', $queue);

        $form->submit($request, false);

        if (false == $form->isValid()) {
            return $this->handleView($this->view($form, 400));
        }

        $this->get('aerial_ship_steel_mq.manager.queue')->update($project, $queue);

Posted from SensioLabsInsight

i3or1s pushed a commit to i3or1s/steel-mq that referenced this issue Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant