Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #58

Open
aherd2985 opened this issue Oct 7, 2020 · 10 comments
Open

Unit tests #58

aherd2985 opened this issue Oct 7, 2020 · 10 comments
Labels
enhancement New feature or request Hacktoberfest hacktoberfest-accepted Hacktoberfest

Comments

@aherd2985
Copy link
Owner

Please feel free to add unit tests, thank you!

@aherd2985 aherd2985 added enhancement New feature or request hacktoberfest-accepted Hacktoberfest labels Oct 7, 2020
@ArmoryNode
Copy link

I can get started on this 👍

@Rollerss
Copy link

Rollerss commented Oct 7, 2020

Do you have a preferred framework for the unit test? Xunit, Nunit, MStest?

@jinkim-tech
Copy link

I can start this too! Please let us know a preferred framework.

@ArmoryNode
Copy link

To add, I think it would help with organization if we moved the code into a src folder. That way we can have the tests live in a tests folder or something to that tune.

@rlodhiya2502
Copy link
Contributor

Ok. Let's do this.

@1RedOne
Copy link
Contributor

1RedOne commented Oct 10, 2020

Just a heads up that I began implementing tests using xUnit and Moq, adding a testable WebClient which should be an easy pattern for others to use if they'd like to add tests to other areas of the project. For samples, see both #83 and #79

@1RedOne
Copy link
Contributor

1RedOne commented Oct 10, 2020

Anyone else interested in adding Unit tests? The next one I am planning is Tests for WeatherUtilities

Edit: Unit tests and new hint pattern for missing creds done in #85

@jinkim-tech
Copy link

I will work on Kanye

@1RedOne
Copy link
Contributor

1RedOne commented Oct 12, 2020

@jinkim-tech Kanye is done already in pr #83, but there are plenty of utilities which could use the same treatment and should be similar :)

For instance, CountryInfo, Covid19Info, and a number of the other utilities are all pretty similar and need tests too

@1RedOne
Copy link
Contributor

1RedOne commented Oct 12, 2020

Checklist for Utilities and whether or not they have tests

  • BitcoinPrices
  • BreakingBadQuotes
  • Calculator
  • CatFact
  • CountryInformation
  • Covid19
  • DadJoke
  • DigitalOcean
  • DiscordSender
  • FBIMostWanted
  • GeekJokes
  • GenderFromName
  • GhostGame
  • HostToIp
  • IUtility
  • KanyeQuote
  • NumberFact
  • PeopleInSpace
  • PortScanner
  • RandomAdvice
  • RandomChuckNorrisJoke
  • RandomFoxFact
  • RandomInsult
  • RandomPandaFact
  • RandomProgrammerQuote
  • RandomQuote
  • RandomQuoteGarden
  • RandomTaco
  • RandomUserGenerator
  • SpaceStationLocation
  • TextMessage
  • WeatherForecast
  • WhoStoleTheCookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest hacktoberfest-accepted Hacktoberfest
Projects
None yet
Development

No branches or pull requests

6 participants