Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide enemy labels if the vanilla target bar is hidden by other mods #28

Open
WaterFace opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request task To do assignment

Comments

@WaterFace
Copy link
Contributor

WaterFace commented Mar 18, 2024

This mod hides enemy name labels on the compass if the enemy health bar is visible, since otherwise they would overlap. It checks whether or not the bar is visible by testing whether or not HUDMenu.EnemyHealth_mc.BracketsInstance._alpha is greater than zero, which corresponds to how the vanilla game hides that bar.

However TrueHUD hides the enemy bar by setting EnemyHealth_mc._alpha to zero, which means it isn't always recognized as hidden by CNO. I haven't confirmed but I believe iHUD does the same thing. This results in enemy name labels disappearing most of the time in combat, even when they wouldn't be overlapping anything.

I think the solution would be to consider the bar hidden when either EnemyHealth_mc.BracketsInstance._alpha or EnemyHealth_mc._alpha is zero. I would submit a PR but I don't really have the tools to work with flash.

@alexsylex
Copy link
Owner

Gotcha, will take a look at it!

@alexsylex alexsylex added enhancement New feature or request task To do assignment labels Mar 18, 2024
@alexsylex alexsylex self-assigned this Mar 18, 2024
@alexsylex alexsylex moved this from Todo to In Progress in Compass Navigation Overhaul Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task To do assignment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants