Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2I: Sending data-json to premiumads API for amp-auto-ads #40041

Closed
rochapablo opened this issue Jun 5, 2024 · 3 comments
Closed

I2I: Sending data-json to premiumads API for amp-auto-ads #40041

rochapablo opened this issue Jun 5, 2024 · 3 comments
Labels
Type: Feature Request

Comments

@rochapablo
Copy link
Contributor

Description

When publisher adds data-json to amp-auto-ads tag (<amp-auto-ads type="premiumads" data-json='{"category":"sports"}') the data will be sent to the premiumads API.

Alternatives Considered

There's none.

Additional Context

image
@rochapablo rochapablo mentioned this issue Jun 5, 2024
Merged
@erwinmombay erwinmombay assigned powerivq and unassigned powerivq Jun 27, 2024
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

2 similar comments
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

powerivq pushed a commit that referenced this issue Aug 20, 2024
@rochapablo
✨ New feature (I2I: Sending data-json to premiumads API for amp-auto-…
51c6913 
…ads #40041 ) (#40042)

* LOND-3031 sendind data-json to api

* LOND-3031 fixing pr-check lint

* LOND-3031 removing unnecessary vertical margin

* LOND-3031 fixing test

* LOND-3031 testing

* LOND-3031 removing comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@powerivq @rochapablo