Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Enhancement for http source/sink connector #5069

Closed
3 tasks done
xwm1992 opened this issue Aug 4, 2024 · 0 comments · Fixed by #5070
Closed
3 tasks done

[Enhancement] Enhancement for http source/sink connector #5069

xwm1992 opened this issue Aug 4, 2024 · 0 comments · Fixed by #5070
Labels
enhancement New feature or request

Comments

@xwm1992
Copy link
Contributor

xwm1992 commented Aug 4, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Since the http source/sink connector uses a queue to achieve asynchronous decoupling, that is, after the source connector receives the request, it puts it into the queue and returns the result. However, it does not know the execution status of the sink side. We need to provide a way to achieve this. The result callback on the sink side is returned to the source side.

Describe the solution you'd like

connectorRecord will have a callback and the sink side will call the onSuccess or onException which are mapped to the commit and onException methods of the source connector respectively.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@xwm1992 xwm1992 added the enhancement New feature or request label Aug 4, 2024
xwm1992 added a commit to xwm1992/EventMesh that referenced this issue Aug 4, 2024
@xwm1992
[ISSUE apache#5069] Enhancement for http source/sink connector
857a6b4
@xwm1992 xwm1992 mentioned this issue Aug 5, 2024
Merged
xwm1992 added a commit that referenced this issue Aug 7, 2024
@xwm1992
[ISSUE #5069] Enhancement for http source/sink connector (#5070)
a6018dd 
* [ISSUE #5069] Enhancement for http source/sink connector

* update http source connector & config

* fix checkstyle error
xwm1992 added a commit that referenced this issue Aug 7, 2024
@xwm1992
[ISSUE #5071] Enhancement for admin server and canal source/sink conn…
691aab0 
…ector (#5072)

* [ISSUE #5069] Enhancement for http source/sink connector

* update http source connector & config

* fix checkstyle error

* [ISSUE #5071] Enhancement for admin server and canal source/sink connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #5069] Enhancement for http source/sink connector xwm1992/EventMesh
1 participant
@xwm1992