Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more and correct one #1

Open
Sh4d0wHunt3rX opened this issue Feb 27, 2024 · 2 comments
Open

Add some more and correct one #1

Sh4d0wHunt3rX opened this issue Feb 27, 2024 · 2 comments

Comments

@Sh4d0wHunt3rX
Copy link

Hi, thanks for this script : )

I was comparing yours with this one which is only the list of sources and sinks:
https://github.com/Sivnerof/Sources-And-Sinks-Cheatsheet

I noticed you wrote:
WINDOWS_SOURCES="windows.name"

I'm not sure, but I guess it should be window.name

Also, I couldn't find these:

document.write()
document.writeln()
element.outerHTML
element.insertAdjacentHTML
element.onevent

The following jQuery functions are also sinks that can lead to DOM-XSS vulnerabilities:

add()
after()
append()
animate()
insertAfter()
insertBefore()
before()
html()
prepend()
replaceAll()
replaceWith()
wrap()
wrapInner()
wrapAll()
has()
constructor()
init()
index()
jQuery.parseHTML()
$.parseHTML()

Thanks : )

@ariary
Copy link
Owner

ariary commented Feb 27, 2024

Thank you !
I've updated the list and fix the typo

I will look for the jquery one later (don't hesitate to make a PR otherwise)

@Sh4d0wHunt3rX
Copy link
Author

Thank you so much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants