-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kafka Adapter to support spec v3 #673
Comments
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Still relevant. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Still relevant. |
@KhudaDad414 @oviecodes I'm willing to work on this issue. Could you please assign me this? |
Describe the bug
We need to update the kafka adapter to support v3 of the spec. Currently, from what I noticed, the parsed methods seem to be different from v2 and it causes the adapter to fail.
How to Reproduce
Update the spec to v3 and run the project in the
examples/kafka-test
directory. First, you'll get an error related to thereply.channel
(I'll have to check more, I'm slightly confused by the reply feature). However, we can get past that by adding a conditional to check forreply
. Finally once thereply.channel
error out of the way, you'll get the following errorTypeError: Cannot read properties of undefined (reading 'type') at file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:29:87 at Array.find (<anonymous>) at KafkaAdapter.<anonymous> (file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:29:69) at Generator.next (<anonymous>) at fulfilled (file:///Users/a/Documents/asyncapi/glee/dist/adapters/kafka/index.js:4:58)
Expected behavior
The Kafka adapter should start correctly without errors.
@Souvikns @KhudaDad414 I'll start working on a fix as this is
blocking #411
.The text was updated successfully, but these errors were encountered: