From 4b2409054723b9b4d5f9d2269884429fa021054c Mon Sep 17 00:00:00 2001
From: Joep Meindertsma <joep@ontola.io>
Date: Sat, 31 Dec 2022 14:09:53 +0100
Subject: [PATCH] Various registration UX improvements #238

---
 .../src/components/RegisterSignIn.tsx         |  5 +-
 data-browser/src/helpers/handlers.tsx         |  2 +
 data-browser/src/routes/ConfirmEmail.tsx      | 79 +++++++++++++------
 data-browser/src/views/ErrorPage.tsx          |  3 +
 lib/src/authentication.ts                     | 29 ++++---
 5 files changed, 82 insertions(+), 36 deletions(-)

diff --git a/data-browser/src/components/RegisterSignIn.tsx b/data-browser/src/components/RegisterSignIn.tsx
index 1697dea71..34da36fae 100644
--- a/data-browser/src/components/RegisterSignIn.tsx
+++ b/data-browser/src/components/RegisterSignIn.tsx
@@ -151,7 +151,6 @@ function Register({ close }) {
             <InputWrapper>
               <InputStyled
                 autoFocus={true}
-                // pattern={emailRegex}
                 type={'email'}
                 required
                 value={email}
@@ -186,8 +185,10 @@ function SignIn() {
       </DialogTitle>
       <DialogContent>
         <SettingsAgent />
-        <p>Lost your passphrase?</p>
       </DialogContent>
+      <DialogActions>
+        <p>Lost your passphrase?</p>
+      </DialogActions>
     </>
   );
 }
diff --git a/data-browser/src/helpers/handlers.tsx b/data-browser/src/helpers/handlers.tsx
index e2374ee76..06313eee3 100644
--- a/data-browser/src/helpers/handlers.tsx
+++ b/data-browser/src/helpers/handlers.tsx
@@ -3,9 +3,11 @@ import BugsnagPluginReact, {
   BugsnagErrorBoundary,
 } from '@bugsnag/plugin-react';
 import React from 'react';
+import { toast } from 'react-hot-toast';
 import { isDev } from '../config';
 
 export function handleError(e: Error): void {
+  toast.error(e.message);
   console.error(e);
 
   if (!isDev) {
diff --git a/data-browser/src/routes/ConfirmEmail.tsx b/data-browser/src/routes/ConfirmEmail.tsx
index f73291d98..23ca32e7f 100644
--- a/data-browser/src/routes/ConfirmEmail.tsx
+++ b/data-browser/src/routes/ConfirmEmail.tsx
@@ -1,11 +1,12 @@
 import { confirmEmail, useStore } from '@tomic/react';
 import * as React from 'react';
 import { useState } from 'react';
-import { CodeBlock } from '../components/CodeBlock';
+import toast from 'react-hot-toast';
+import { Button } from '../components/Button';
+import { CodeBlockStyled } from '../components/CodeBlock';
 import { ContainerNarrow } from '../components/Containers';
 import { isDev } from '../config';
 import { useSettings } from '../helpers/AppSettings';
-import { handleError } from '../helpers/handlers';
 import {
   useCurrentSubject,
   useSubjectParam,
@@ -19,10 +20,13 @@ const ConfirmEmail: React.FunctionComponent = () => {
   const [secret, setSecret] = useState('');
   const store = useStore();
   const [token] = useSubjectParam('token');
-  const { agent, setAgent } = useSettings();
+  const { setAgent } = useSettings();
   const [destinationToGo, setDestination] = useState<string>();
+  const [err, setErr] = useState<Error | undefined>(undefined);
+  const [triedConfirm, setTriedConfirm] = useState(false);
 
-  const handleConfirm = async () => {
+  const handleConfirm = React.useCallback(async () => {
+    setTriedConfirm(true);
     let tokenUrl = subject as string;
 
     if (isDev()) {
@@ -37,37 +41,68 @@ const ConfirmEmail: React.FunctionComponent = () => {
         store,
         tokenUrl,
       );
-      setAgent(newAgent);
       setSecret(newAgent.buildSecret());
       setDestination(destination);
+      setAgent(newAgent);
+      toast.success('Email confirmed!');
     } catch (e) {
-      handleError(e);
+      setErr(e);
+    }
+  }, [subject]);
+
+  if (!triedConfirm && subject) {
+    handleConfirm();
+  }
+
+  if (err) {
+    if (err.message.includes('expired')) {
+      return (
+        <ContainerNarrow>
+          The link has expired. Request a new one by Registering again.
+        </ContainerNarrow>
+      );
     }
-  };
 
-  if (!agent) {
-    return (
-      <ContainerNarrow>
-        <button onClick={handleConfirm}>confirm</button>
-      </ContainerNarrow>
-    );
+    return <ContainerNarrow>{err?.message}</ContainerNarrow>;
+  }
+
+  if (secret) {
+    return <SavePassphrase secret={secret} destination={destinationToGo} />;
+  }
+
+  return <ContainerNarrow>Verifying token...</ContainerNarrow>;
+};
+
+function SavePassphrase({ secret, destination }) {
+  const [copied, setCopied] = useState(false);
+
+  function copyToClipboard() {
+    setCopied(secret);
+    navigator.clipboard.writeText(secret || '');
+    toast.success('Copied to clipboard');
   }
 
   return (
     <ContainerNarrow>
-      <h1>Save your Passphrase</h1>
+      <h1>Mail confirmed, please save your passphrase</h1>
       <p>
         Your Passphrase is like your password. Never share it with anyone. Use a
-        password manager to store it securely. You will need this to log in
-        next!
+        password manager like{' '}
+        <a href='https://bitwarden.com/' target='_blank' rel='noreferrer'>
+          BitWarden
+        </a>{' '}
+        to store it securely.
       </p>
-      <CodeBlock content={secret} wrapContent />
-      {/* <Button onClick={handleGoToDestination}>Continue here</Button> */}
-      <a href={destinationToGo} target='_blank' rel='noreferrer'>
-        Open my new Drive!
-      </a>
+      <CodeBlockStyled wrapContent>{secret}</CodeBlockStyled>
+      {copied ? (
+        <a href={destination} target='_blank' rel='noreferrer'>
+          {"I've saved my PassPhrase, open my new Drive!"}
+        </a>
+      ) : (
+        <Button onClick={copyToClipboard}>Copy Passphrase</Button>
+      )}
     </ContainerNarrow>
   );
-};
+}
 
 export default ConfirmEmail;
diff --git a/data-browser/src/views/ErrorPage.tsx b/data-browser/src/views/ErrorPage.tsx
index 7942f09f1..644ecc19a 100644
--- a/data-browser/src/views/ErrorPage.tsx
+++ b/data-browser/src/views/ErrorPage.tsx
@@ -24,6 +24,9 @@ function ErrorPage({ resource }: ResourcePageProps): JSX.Element {
   }, [agent]);
 
   if (isUnauthorized(resource.error)) {
+    // This might be a bit too aggressive, but it fixes 'Unauthorized' messages after signing in to a new drive.
+    store.fetchResource(subject);
+
     return (
       <ContainerWide>
         <Column>
diff --git a/lib/src/authentication.ts b/lib/src/authentication.ts
index c0beeb2f4..a894fe12f 100644
--- a/lib/src/authentication.ts
+++ b/lib/src/authentication.ts
@@ -152,6 +152,7 @@ export async function register(
  * If there is no agent in the store, a new one will be created.  */
 export async function confirmEmail(
   store: Store,
+  /** Full http URL including the `token` query parameter */
   tokenURL: string,
 ): Promise<{ agent: Agent; destination: string }> {
   const url = new URL(tokenURL);
@@ -199,17 +200,21 @@ export async function confirmEmail(
 }
 
 function parseJwt(token) {
-  const base64Url = token.split('.')[1];
-  const base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/');
-  const jsonPayload = decodeURIComponent(
-    window
-      .atob(base64)
-      .split('')
-      .map(function (c) {
-        return '%' + ('00' + c.charCodeAt(0).toString(16)).slice(-2);
-      })
-      .join(''),
-  );
+  try {
+    const base64Url = token.split('.')[1];
+    const base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/');
+    const jsonPayload = decodeURIComponent(
+      window
+        .atob(base64)
+        .split('')
+        .map(function (c) {
+          return '%' + ('00' + c.charCodeAt(0).toString(16)).slice(-2);
+        })
+        .join(''),
+    );
 
-  return JSON.parse(jsonPayload);
+    return JSON.parse(jsonPayload);
+  } catch (e) {
+    throw new Error('Invalid token: ' + e);
+  }
 }