-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library version 1.7.1 crashes Aurelia CLI Bundler builds #131
Comments
meh, sry about that. It seems I've added the typings fir the extension as devDependency instead of prod. meanwhile please |
@LukevanTricht v1.7.2 has been released and should address this issue. Please take a look and see whether it works for you |
@zewa666 It looks like you're missing a dependency that @redux-devtools requires, I got this warning doing the upgrade:
And my build failed with:
|
that's super weird, as I've tested it out with a fresh new CLI project without any troubles. Although I must admit it was Webpack now that I think. Anyways, seems they're having the same type of issue I had of using a devDependency as prod :( I'm definitely not interested in adding Redux as a dependency as that goes way too far just for the sake of typings. The offending line is here. I'm not sure whether a type-only import would perhaps remove the issue or whether this is something specific to the CLI bundler. @3cp any ideas? EDIT: |
I'm submitting a bug report
1.7.1
Please tell us about your environment:
Operating System:
WSL (Ubuntu)
Node Version:
v16.14.0
NPM Version:
8.3.1
JSPM OR Webpack AND Version
Aurelia-CLI v2.0.3
Browser:
Chrome 99
Language:
TypeScript 4.6.2
Current behavior:
After upgrading from 1.7.0 to 1.7.1, my build now crashes with the following error:
Expected/desired behavior:
Hopefully, a patch update like this shouldn't have killed the build process.
Replication Steps(Can provide a minimal project as a repo if you'd like):
yarn add aurelia-store
aurelia-store
object(I choseconnectTo
)yarn build
The text was updated successfully, but these errors were encountered: