-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle browser maximum height #30
Comments
@vegarringdal Not yet. It is on the list of improvements. Right now working on getting array mutations right. |
Hope you don't mind I changed the title, want to keep this issue for future reference. |
No problem :-) |
@martingust Status? |
@vegarringdal @EisenbergEffect This might work for @vegarringdal last comment #71 (comment) |
Hi (in my grid, maybe you have done it in a way thats better, and dont have this issue) What I used to test with...
|
Is there any progress in this area? The demo http://aurelia.io/ui-virtualization/ still seems to suffer from the div height limitation. If I add 200k rows in Chrome (Vivaldi) and scroll to the bottom I get a blank area. |
@leak, there hasn't been progress made, but we'd love help from the community! My current thought process for solving this is to some fancy tracking with ratios. Basically, once we reach a certain height (items * individual item height), the browser's scroll wheel will already be at it's minimum size. At that point, it doesn't matter visually if more items are in the list or not, so it's at that point that we stop adding buffer heights to the window (since that's whats causing the problem) and start using some fancy ratio work (thinking a bit about this as I type). Once we reach our maximum browser height, when we're scrolling down in the list, we can't just remove buffer height on a per item basis (scrolled 5 elements down, 5 elements worth of buffer height goes to the top buffer), instead, we use a fraction (depending on our browser/item height ratio) of the buffer height to move to the top, simulating us scrolling through a larger list than we actually are showing. Does that kind of make sense? That's at least where we are at currently. Again, any help would be greatly appreciated. |
Haven't really seen a solution yet that doesn't have issues. This is performance-wise probably one of the best I've found so far, it seems to use some virtual paging: Small problem though, if you click on the free area of the scroll bar for scrolling, the thumb starts jumping. **edit |
Nice. If you're interested, you could make a branch and try implementing that in there, see if we can't get some movement on that. |
Hi again :-)
See you have added native scrolling.
Have you overcome the issues virtual scrolling can get with browser div maximum height?
Usually it will never be a issue for 99.99% of all grids/scrollers since user dont need to see that much data/scroll it.
Just wanted to know because I wanted to add it to my hobby grid project here:
https://github.com/vegarringdal/simpleGrid.
Plan was to try and make it into a custom element, just need to learn A LOT more first :-)
The text was updated successfully, but these errors were encountered: