Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines at top of tabs and some other questions #2

Open
PixelatedVolume opened this issue Nov 15, 2017 · 8 comments
Open

Lines at top of tabs and some other questions #2

PixelatedVolume opened this issue Nov 15, 2017 · 8 comments

Comments

@PixelatedVolume
Copy link

PixelatedVolume commented Nov 15, 2017

I've encountered strange lines at the top of my tabs using this (pretty great) mod. Observe: https://i.imgur.com/uGOd8RO.png

Also, when I open more tabs than will fit on the page, they don't shrink and pile up, they just start flying off the page, moving the "add tab" button off the page. There's also no way to close a tab while viewing another tab. Are these features?

@axydavid
Copy link
Owner

axydavid commented Nov 16, 2017

  1. Yes, I only have the close button on the active tab, remove line 8 and you should have the close button for all tabs.
  2. For the mentioned bugs please make sure you're using the dafault light theme and the normal density.
    If you indeed are then make sure you don't have any other chrome css scripts that might affect this one.
  3. If you have neither, then tell me your firefox version or branch(normal, beta, dev or nightly). I'll have a look then and see what causes that abominable line on the top of these beautiful tabs.
    I don't see this problem on my PC tho,however I feel it's time to make an update soon.
    Thanks for your time in opening this issue tho, I appreciate that people are interested in this script, you're an awesome human for that :) 👍

@axydavid
Copy link
Owner

axydavid commented Nov 16, 2017

OH, You might wanna try to uncomment the /* NIGHTLY FIX */ section of the css code(line 11 trough 20), maybe that solves your issue, if it does, please tell me along with your firefox version.

@PixelatedVolume
Copy link
Author

  1. Removing 8 fixed that thank you very much :)

  2. I am using the default theme and normal density. I don't have any other scripts going. Uncommenting "Nightly Fix" actually made the problem worse, it pushed the left part of each tab up about ten or fifteen pixels.

I'm using Firefox v57.0 on Windows 10 x64.

You're the awesome human here my man. I was trying to do some of this stuff myself earlier and it just about made my eyes bleed. Thanks for what you do.

@axydavid
Copy link
Owner

axydavid commented Nov 16, 2017

Allright, I'll have a look at it once I get home, I'll push a fix today or tomorrow.
I agree it's not very easy to get the old skin back, but not impossible either.

@PixelatedVolume
Copy link
Author

Thanks! I've made a couple little tweaks to make the Photon version a little more bearable but I appreciate your effort.

@axydavid
Copy link
Owner

axydavid commented Nov 16, 2017

image
I see no issues in my firefox 47.

  1. Make sure that your custom userChrome tweaks are disabled.

  2. Uninstall all legacy extentions.

  3. Make sure that you don't have any other addons that affect the theme.

  4. Easiest way to do it is to reset Firefox which is the same as switching local profiles, you will loose all your addons and options if you are not synced.

@PixelatedVolume
Copy link
Author

Well, I discovered the problem. Turning on the menu toolbar makes the lines appear on the tabs.

Don't sweat the issue too much -- I'm getting used to Photon. Just thought I'd let you know.

@axydavid
Copy link
Owner

axydavid commented Nov 17, 2017

Not a lot of people are using menu toolbar much, it seems you are a very old firefox user.
However in nightlly even if I fix the lines issue some of the image flies in a very weird matter.
I rarelly use the menu, however i just press the Alt key which temporarlly shows the menu, that seems to work fine with the tabs. Perhaps this is a compromise you'd be willing to accept. You can use this menu by using the key shortcuts.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants