Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check overwrite avoidance in generate_verses_from_unknown #35

Open
2 tasks
bensteUEM opened this issue Mar 7, 2024 · 0 comments
Open
2 tasks

check overwrite avoidance in generate_verses_from_unknown #35

bensteUEM opened this issue Mar 7, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
1.0.x

Comments

@bensteUEM
Copy link
Owner

bensteUEM commented Mar 7, 2024 •
edited
Loading

generate_verses_from_unknown currently overwrites existing blocks if they already exist when converting an unknown block.

  • It would be better to enumerate blocks if they exist
  • optionally add test case for logged warning when new verse already exists in VerseOrder
@bensteUEM bensteUEM added the bug Something isn't working label Mar 7, 2024
bensteUEM added a commit that referenced this issue Mar 7, 2024
@bensteUEM
fix #27; link and define #13,#14,#29,#30,#32,#33,#34,#35,#36
1bc28c5
bensteUEM added a commit that referenced this issue May 7, 2024
@bensteUEM
fix #27; link and define #13,#14,#29,#30,#32,#33,#34,#35,#36
780b622
@bensteUEM bensteUEM added this to the 1.0.x milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
1 participant
@bensteUEM